Skip to content

Conversation

@ShahzaibIbrahim
Copy link
Contributor

The deprecated method getImageDataAtCurrentZoom() in Image is marked for removal along with its tests.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

Test Results

   545 files  ±0     545 suites  ±0   30m 46s ⏱️ +54s
 4 406 tests ±0   4 388 ✅ ±0   18 💤 ±0  0 ❌ ±0 
16 745 runs  ±0  16 603 ✅ ±0  142 💤 ±0  0 ❌ ±0 

Results for commit bfa5130. ± Comparison against base commit 7f3f080.

♻️ This comment has been updated with latest results.

The deprecated method getImageDataAtCurrentZoom() in Image is marked for
removal along with its tests.
@ShahzaibIbrahim ShahzaibIbrahim force-pushed the master-351-getDataCurrentZoom branch from 89bc70a to bfa5130 Compare July 8, 2025 11:18
Copy link
Member

@fedejeanne fedejeanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR makes sense, it's about time to get rid of this method that has been deprecated since April 2017 (a200595, eb6b62d).

@fedejeanne
Copy link
Member

Since there are no more code owners since 8d8dd80, I will ask directly @iloveeclipse (GTK) and @BeckerWdf (Mac): any objections to this PR?

If there are no objections by tomorrow, I will merge the PR.

@fedejeanne fedejeanne merged commit a5b1dcb into eclipse-platform:master Jul 21, 2025
17 checks passed
@fedejeanne fedejeanne deleted the master-351-getDataCurrentZoom branch July 21, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mark Deprecated method Image::getImageDataAtCurrentZoom for removal

2 participants